created login forms for ssf and pantry #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanzzz368
approved these changes
Oct 27, 2024
sam-schu
reviewed
Nov 3, 2024
| return ( | ||
| <div> | ||
| <Header /> | ||
| <Outlet /> | ||
| {ssf ? <SSFLoginForm /> : <PantryLoginForm />} |
There was a problem hiding this comment.
Assuming this PR corresponds to this ticket, should we be adding this to /landing-page instead? Right now, the login forms show up on every page on the site because all pages show the root content.
There was a problem hiding this comment.
goot catch sam i have moved it to the landing page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
Added a component file for two types of login forms
put them on the root.tsx file to test
added button to switch between the two types of login forms
✔️ Verification
🏕️ (Optional) Future Work / Notes
missing backend and styling