Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move add map changes to new PR, add map to tree page fixing dispatch and merge conflict #341

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

SurabhiKeesara
Copy link
Contributor

Checklist

  • 1. Run yarn run check
  • 2. Run yarn run test

Why

Resolves #325

This change adds a map to the tree info page, allowing users to see where the tree exists relative to other trees and the entire map of Boston

This PR

Changes include

  • Adding a map height parameter to make the height of the map component specifiable depending on where it is called from
  • Adding sites and neighborhoods fields to tree props so that the map component can display the entire map of all other sites
  • Define a state for the map marker and position
  • Add the actual map component to a tree page

Screenshots

Screenshot 2024-02-28 at 4 23 03 PM Screenshot 2024-02-28 at 4 22 55 PM

Verification Steps

To verify that this works

  • Select a site from the home page
  • Select 'More Info', open in a new tab
  • Note that a map exists on the more info page
  • Ensure that the map position on the tree page matches the tree position on the home page

@SurabhiKeesara SurabhiKeesara merged commit 12acfcb into master Mar 24, 2024
4 of 5 checks passed
@SurabhiKeesara SurabhiKeesara deleted the SK.add-map-to-tree-page-add-dispatch branch March 24, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Map to Tree Info Page
2 participants