Emailer: preview HTML content before sending #324
Conversation
| > | ||
| <Input.TextArea rows={6} placeholder="Email Body" /> | ||
| <Input.TextArea rows={8} placeholder={t('body_placeholder')} /> |
There was a problem hiding this comment.
What's the reason to set the row to 8? if the user has less than 8 lines, would it just show a bunch of white spaces?
There was a problem hiding this comment.
Yep, it's just making the textbox for the the email body a little bigger (see pic). No real important reason behind this, I just thought it'd be nice to have a little more space to view the email HTML (before/after):
| form={sendEmailForm} | ||
| onFinish={onFinishSendEmail} | ||
| onValuesChange={(changedValues, _) => { | ||
| if (changedValues.emailBody !== undefined) |
There was a problem hiding this comment.
if the emailBody is undefined, would we want to prompt the user to do anything? or just ignore until they input something that's valid.
There was a problem hiding this comment.
Good question! In this case, emailBody would be undefined only when the user edits a field that's not the body, since changedValues only contains fields that were modified when the user inputs something. This check is just to make sure we don't accidentally clear the body when the user modifies the subject.
Checklist
yarn run checkyarn run testWhy
Resolves #275
On the emailer page, add a toggle to preview email HTML before sending
This PR
Screenshots
Raw view:
Preview view:
Verification Steps