Ot.language options #319
Merged
Ot.language options #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| key: 'es', | ||
| label: 'Español', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Will we be easily able to add other languages to this array? Does this just use the i18 language library/autotranslate?
There was a problem hiding this comment.
Yep! As long we have the translations for other languages, we can just add their key and appropriate label for languages here. We'll just need to make sure that the key we specify here matches what we use in src/i18n/i18n.ts where we map languages to translation files.
SurabhiKeesara
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run checkyarn run testWhy
Resolves #234
Provides a dropdown button for users to switch languages (if available)
This PR
removed FlexBar component from mobileNavBar, replaced with Flex. There is still some weird alignment issue with the button, so that needs to be fixed
Screenshots
Verification Steps
Ran the frontend, changed languages successfully