Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change favicon and title #32

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Change favicon and title #32

wants to merge 8 commits into from

Conversation

nadishiro17
Copy link

ℹ️ Issue

Closes

📝 Description

I've changed the favicon and main page name.

Changes made to the code:

  1. Replaced previous favicon with a new one.
  2. Changed the page name(title) in html and app.tsx files.

✔️ Verification

I run the app, everything works. I'll add a screenshot for confirmation.
Screenshot 2024-09-26 at 18 06 02

🏕️ (Optional) Future Work / Notes

CerberusLatrans
CerberusLatrans requested changes Sep 28, 2024
View reviewed changes
Copy link

@CerberusLatrans CerberusLatrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but why is this a PR on the scaffolding repo? Shouldn't it be on the SSF repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CerberusLatrans CerberusLatrans CerberusLatrans requested changes

@fanzzz368 fanzzz368 fanzzz368 approved these changes

@sam-schu sam-schu Awaiting requested review from sam-schu

@denniwang denniwang Awaiting requested review from denniwang

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadishiro17 @CerberusLatrans @fanzzz368 @huang0h