Sg ls postevents #81
Merged
Sg ls postevents #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejamielin
reviewed
Nov 4, 2022
There was a problem hiding this comment.
just got through the README but will make more comments today or tomorrow! great work so far @lucass0717 and @surbhi-gulati
thejamielin
reviewed
Nov 13, 2022
There was a problem hiding this comment.
lgtm! made a single comment about consistency with naming but otherwise amazing work @surbhi-gulati and @lucass0717
rymaju
reviewed
Nov 13, 2022
adriannaliu
requested changes
Nov 14, 2022
thejamielin
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #47
📝 Description
✔️ Verification
Ran
npm run testand encountered only one error that will be resolved when GET Programs is implemented🏕️ (Optional) Future Work / Notes
Potentially abstract schema changes into its own ticket.
Issue #46 should use 'programs' as the naming convention for what was previously news / events