Changed the type error in decision

Code-4-Community · Mar 12, 2024 · 7139655 · 7139655
1 parent 6da21ab
commit 7139655
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 7 deletions.
diff --git a/apps/backend/src/app.module.ts b/apps/backend/src/app.module.ts
@@ -13,6 +13,7 @@ import { ApplicationsModule } from './applications/applications.module';
   imports: [
     TypeOrmModule.forRoot({
       type: 'postgres',
+      database: 'c4c-ops',
       host: process.env.NX_DB_HOST,
       port: 5432,
       username: process.env.NX_DB_USERNAME,

diff --git a/apps/backend/src/applications/applications.controller.ts b/apps/backend/src/applications/applications.controller.ts
@@ -12,7 +12,7 @@ import {
   NotFoundException,
   UnauthorizedException,
 } from '@nestjs/common';
-import { Response } from './types';
+import { Decision, Response } from './types';
 import { ApplicationsService } from './applications.service';
 import { CurrentUserInterceptor } from '../interceptors/current-user.interceptor';
 import { AuthGuard } from '@nestjs/passport';
@@ -51,6 +51,12 @@ export class ApplicationsController {
       throw new UnauthorizedException();
     }
 
+    //Check if the string decision matches with the Decision enum
+    const decisionEnum: Decision = Decision[decision as keyof typeof Decision];
+    if (!decisionEnum) {
+      throw new BadRequestException('Invalid decision value');
+    }
+
     //Check if the user exists and if the user has an application for the current cycle
     const applicant = await this.applicationsService.findCurrent(applicantId);
     if (!applicant) {
@@ -60,7 +66,7 @@ export class ApplicationsController {
     }
 
     //Delegate the decision making to the service.
-    await this.applicationsService.processDecision(applicantId, decision);
+    await this.applicationsService.processDecision(applicantId, decisionEnum);
   }
 
   @Get('/:userId')

diff --git a/apps/backend/src/applications/applications.service.ts b/apps/backend/src/applications/applications.service.ts
@@ -8,7 +8,7 @@ import { MongoRepository } from 'typeorm';
 import { UsersService } from '../users/users.service';
 import { Application } from './application.entity';
 import { getAppForCurrentCycle, getCurrentCycle } from './utils';
-import { Response } from './types';
+import { Decision, Response } from './types';
 import * as crypto from 'crypto';
 import { User } from '../users/user.entity';
 import { Position, ApplicationStage, ApplicationStep } from './types';
@@ -98,27 +98,27 @@ export class ApplicationsService {
    */
   async processDecision(
     applicantId: number,
-    decision: 'ACCEPT' | 'REJECT',
+    decision: Decision,
   ): Promise<void> {
     const applicant = await this.findCurrent(applicantId);
 
     let newStage: ApplicationStage;
     switch (applicant.stage) {
       case ApplicationStage.RESUME:
         newStage =
-          decision === 'ACCEPT'
+          decision === Decision.ACCEPT
             ? ApplicationStage.TECHNICAL_CHALLENGE
             : ApplicationStage.REJECTED;
         break;
       case ApplicationStage.TECHNICAL_CHALLENGE:
         newStage =
-          decision === 'ACCEPT'
+          decision === Decision.ACCEPT
             ? ApplicationStage.INTERVIEW
             : ApplicationStage.REJECTED;
         break;
       case ApplicationStage.INTERVIEW:
         newStage =
-          decision === 'ACCEPT'
+          decision === Decision.ACCEPT
             ? ApplicationStage.ACCEPTED
             : ApplicationStage.REJECTED;
         break;

diff --git a/apps/backend/src/applications/types.ts b/apps/backend/src/applications/types.ts
@@ -30,3 +30,8 @@ export enum Position {
   PM = 'PRODUCT_MANAGER',
   DESIGNER = 'DESIGNER',
 }
+
+export enum Decision {
+  ACCEPT = 'ACCEPT',
+  REJECT = 'REJECT',
+}