Issue 88: Add examples as own projects in examples folder #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problematically, #79 showed an error that only surfaced at runtime in the todomvc example. As a result of the changes here, it seems like we won't be able to find these errors as easily, because the examples depend upon a version of Precept on Clojars. We could potentially
lein pomanduberjar, but fundamentally we shouldn't have to use an example project to detect runtime errors in cljs. Hopefully we can have a test setup that would give us the same result. Any input on this would be appreciated. We have #61 open for CLJS tests in general.