fix: tsoa rule not acknowledging success response decorator (#23)

* fix valid-alternative-response rule to acknowledge SuccessResponse decorator * bump version
CloudNStoyan · Dec 7, 2024 · 131a02f · 131a02f
1 parent e549645
commit 131a02f
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/eslint-plugin-tsoa/package.json b/eslint-plugin-tsoa/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@arabasta/eslint-plugin-tsoa",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "type": "commonjs",
   "description": "ESLint plugin for tsoa rules",
   "author": "Stoyan Kolev",

diff --git a/eslint-plugin-tsoa/src/eslint-plugin-tsoa.ts b/eslint-plugin-tsoa/src/eslint-plugin-tsoa.ts
@@ -15,7 +15,7 @@ import requirePropertyExampleDecoratorRule from './rules/require-property-exampl
 const plugin = {
   meta: {
     name: '@arabasta/eslint-plugin-tsoa',
-    version: '1.1.0',
+    version: '1.1.1',
   },
   configs: {},
   rules: {

diff --git a/eslint-plugin-tsoa/src/rules/valid-alternative-response.test.ts b/eslint-plugin-tsoa/src/rules/valid-alternative-response.test.ts
@@ -55,6 +55,17 @@ ruleTester.run(
         }
         `,
       },
+      {
+        name: 'when this.noContentResult is used in a method that has the `@SuccessResponse` decorator',
+        code: normalizeIndent`
+        class User {
+          @SuccessResponse(204)
+          getAllUsers() {
+            return this.noContentResult();
+          }
+        }
+        `,
+      },
       {
         name: 'when this.noContentResult is used in a method that is inside a class that has the correct response decorator',
         code: normalizeIndent`

diff --git a/eslint-plugin-tsoa/src/rules/valid-alternative-response.ts b/eslint-plugin-tsoa/src/rules/valid-alternative-response.ts
@@ -133,6 +133,10 @@ export default createRule<RuleOptions, RuleMessageIds>({
             node,
             decoratorName: 'Response',
           }),
+          ...getAllDecoratorsWithName({
+            node,
+            decoratorName: 'SuccessResponse',
+          }),
           ...getAllDecoratorsWithName({
             node: currentClassDeclarationNode,
             decoratorName: 'Response',