Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dropdown-menu highlight overview links #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: dropdown-menu highlight overview links #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6095b7d
Fix: dropdown-menu highlight overview links
rdela Aug 2, 2024
ce15732
Add missing event.url
rdela Aug 21, 2024
dbd695e
Use item.link for section.items
rdela Aug 23, 2024
17fd578
Also use item.link for section.items in mobile
rdela Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion component-library/components/events/events.eleventy.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{{ event.date }}
</time>
<div class="info">
<h3><a href="">{{ event.title }}</a></h3>
<h3><a href="{{ event.url }}">{{ event.title }}</a></h3>
<p>{{ event.time }}</p>
</div>
</article>
Expand Down
4 changes: 2 additions & 2 deletions src/_data/main_nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"title": "Admissions",
"overview": {
"title": "Admissions Overview",
"link": "/admission-overview",
"link": "#",
"media": {
"image": "/assets/students.jpg",
"alt": "Students in the admissions office"
Expand Down Expand Up @@ -75,7 +75,7 @@
"title": "Academics",
"overview": {
"title": "Academics Overview",
"link": "/academics-overview",
"link": "#",
"media": {
"image": "/assets/studying.jpg",
"alt": "Students studying"
Expand Down
4 changes: 2 additions & 2 deletions src/_includes/nav/_main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="dropdown-menu" id="dropdown-{{ forloop.index }}">
<div class="dropdown-content" >
<section class="highlight">
<a href="{{ nav_item.overview.title }}">
<a href="{{ nav_item.overview.link }}">
<div class="media">
{% image nav_item.overview.media.image nav_item.overview.media.alt 300 %}
</div>
Expand All @@ -25,7 +25,7 @@
<ul>
{% for item in section.items %}
<li>
<a href="#">
<a href="{{ item.link }}">
{{ item.title }}
</a>
</li>
Expand Down
4 changes: 2 additions & 2 deletions src/_includes/nav/_mobile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<div class="dropdown-menu" id="inner-mobile-menu-{{ forloop.index }}">
<div class="inner-mobile-menu">
<section class="highlight">
<a href="{{ nav_item.overview.title }}">
<a href="{{ nav_item.overview.link }}">
{{ nav_item.overview.title }}
</a>
</section>
Expand All @@ -31,7 +31,7 @@
<ul>
{% for item in section.items %}
<li>
<a href="#">
<a href="{{ item.link }}">
{{ item.title }}
</a>
</li>
Expand Down
6 changes: 3 additions & 3 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@
title: Upcoming events
events:
- date: Jan 15
url:
url: '#'
title: Spring semester begins
time: 2pm-3pm Union Hall
- date: Feb 10
url:
url: '#'
title: Open house
time: 1pm-3pm Lincoln Center
- date: Mar 5
url:
url: '#'
title: Research symposium
time: 10am-12pm Quad Building
button:
Expand Down