Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fixed series navigation by addign a check to ensure article.seri… #181

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

rehanhaider
Copy link
Contributor

…es is a vlid object and not string

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces an enhancement by adding a new content file related to AWS CDK and modifies the settings for paginated templates. The primary focus seems to be on extending the documentation and refining the configuration settings within the project.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
📝 Issue not addressed: this change does not correctly address the issue or implement the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the changes made in the settings.py file are thoroughly tested, especially if they might affect the functionality or structure of the site's pagination. It's important to verify that these changes do not inadvertently impact other parts of the site.
  • Given the pull request description mentions fixing an issue with article.series, it would be beneficial to include more context or code changes directly addressing this fix. If the changes are not included in this pull request, consider updating the description to more accurately reflect the content of the changes.
  • For the new content file added, consider how it integrates with the rest of the documentation or content structure. Ensure that it follows any existing content guidelines and is accessible from the relevant parts of the site or documentation.
  • Review the pull request title and description for clarity and accuracy. The title mentions a fix related to article.series, but the provided changes do not directly address this. Clarifying the title and description to better match the content of the changes would improve the transparency and intent of the pull request.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

settings.py Show resolved Hide resolved
Copy link

github-actions bot commented Mar 3, 2024

Visit the preview URL for this PR (updated for commit 5347f5d):

https://cloudbytes-prod--pr181-fix-8jl8jvzz.web.app

(expires Sun, 10 Mar 2024 05:31:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 961a4e26b5a36b8e33724e90b08761d193134b7b

@rehanhaider rehanhaider merged commit 28e70c3 into main Mar 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant