Merge pull request #578 from brunosabot/fix/feedbac-element-pointer

fix: Prevent the feedback element to be clicked
Clooos · Jun 14, 2024 · 81db665 · 81db665
2 parents e0ae933 + 5ae45fa
commit 81db665
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/cards/button/styles.ts b/src/cards/button/styles.ts
@@ -159,6 +159,7 @@ export default `
         width: 100%;
         height: 100%;
         background-color: rgb(0,0,0);
+        pointer-events: none;
     }
 
     @keyframes tap-feedback {

diff --git a/src/tools/tap-actions.ts b/src/tools/tap-actions.ts
@@ -29,6 +29,7 @@ class ActionHandler {
 
     this.startTime = Date.now();
     clearTimeout(this.tapTimeout);
+    this.tapTimeout = null;
   }
 
   handleEnd() {
@@ -42,16 +43,16 @@ class ActionHandler {
     this.startTime = null;
 
     const doubleTapAction = this.config?.double_tap_action || this.defaultActions?.double_tap_action || { action: "toggle" };
-    const doubleTapTimeout = doubleTapAction.action === "none" ? 0 : 200;
+    const localDoubleTapTimeout = doubleTapAction.action === "none" ? 0 : doubleTapTimeout;
 
     if (holdDuration > maxHoldDuration) {
       this.sendActionEvent(this.element, this.config, 'hold', this.defaultEntity, this.defaultActions);
-    } else if (doubleTapDuration < doubleTapTimeout) {
+    } else if (doubleTapDuration < localDoubleTapTimeout) {
       this.sendActionEvent(this.element, this.config, 'double_tap', this.defaultEntity, this.defaultActions);
     } else {
       this.tapTimeout = setTimeout(() => {
         this.sendActionEvent(this.element, this.config, 'tap', this.defaultEntity, this.defaultActions);
-      }, doubleTapTimeout);
+      }, localDoubleTapTimeout);
     }
   }
 }