Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #81 - setuptools not explicit in all distros - switch to uv #82

Merged
merged 21 commits into from
Nov 25, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Nov 4, 2024

Description

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (7eebded) to head (c027f70).

Files with missing lines Patch % Lines
stranger/resources/__init__.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   91.18%   90.72%   -0.46%     
==========================================
  Files           8        8              
  Lines         397      399       +2     
==========================================
  Hits          362      362              
- Misses         35       37       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previosly I was able to use pip install --editable . as described in the README. I can't seem to do the same in this branch. Could you update the readme if needed?

@dnil
Copy link
Collaborator Author

dnil commented Nov 5, 2024

Definitely! I should have marked as draft - it still needs a few connecting bolts here and there especially in docs.

@dnil dnil marked this pull request as draft November 5, 2024 11:10
@dnil dnil marked this pull request as ready for review November 22, 2024 17:07
@dnil
Copy link
Collaborator Author

dnil commented Nov 22, 2024

Definitely! I should have marked as draft - it still needs a few connecting bolts here and there especially in docs.

Ok, should be fixed now. I think this is the first all on uv/hatchling now, so I probably forgot a ton of things, but at least setup and running should be fine!

@dnil dnil merged commit 5fbae0d into main Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix setup tools compatibility issues
4 participants