Verify the response string length overflow and throw a specific error #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #106
According to this commit, the client now throws a specific error if the result string length is more than the max allowed string length in V8, which is
2**29 - 24
on a 64-bit platform.Previously, the exception was too ambiguous:
RangeError: Invalid string length
InternalError: allocation size overflow
Now, the error message is supposed to be more clear.
Checklist