return readonly array on useDatabases hook

ClickHouse · Nov 29, 2023 · 8f1d50c · 8f1d50c
1 parent d95d0bb
commit 8f1d50c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/hooks/useDatabases.test.ts b/src/hooks/useDatabases.test.ts
@@ -5,7 +5,7 @@ import useDatabases from './useDatabases';
 
 describe('useDatabases', () => {
   it('should return empty array if invalid datasource is provided', async () => {
-    let result: { current: string[] };
+    let result: { current: readonly string[] };
     await act(async () => {
       const r = renderHook(() => useDatabases(undefined!));
       result = r.result;
@@ -18,7 +18,7 @@ describe('useDatabases', () => {
     const mockDs = {} as Datasource;
     mockDs.fetchDatabases = jest.fn(() => Promise.resolve(['a', 'b']));
 
-    let result: { current: string[] };
+    let result: { current: readonly string[] };
     await act(async () => {
       const r = renderHook(() => useDatabases(mockDs));
       result = r.result;

diff --git a/src/hooks/useDatabases.ts b/src/hooks/useDatabases.ts
@@ -1,7 +1,7 @@
 import { useState, useEffect } from 'react';
 import { Datasource } from 'data/CHDatasource';
 
-export default (datasource: Datasource): string[] => {
+export default (datasource: Datasource): readonly string[] => {
   const [databases, setDatabases] = useState<string[]>([]); 
 
   useEffect(() => {

diff --git a/src/hooks/useTables.test.ts b/src/hooks/useTables.test.ts
@@ -5,7 +5,7 @@ import useTables from './useTables';
 
 describe('useTables', () => {
   it('should return empty array if invalid datasource is provided', async () => {
-    let result: { current: string[] };
+    let result: { current: readonly string[] };
     await act(async () => {
       const r = renderHook(() => useTables(undefined!, 'db'));
       result = r.result;
@@ -18,7 +18,7 @@ describe('useTables', () => {
     const mockDs = {} as Datasource;
     mockDs.fetchTables = jest.fn((db: string) => Promise.resolve(['a', 'b']));
 
-    let result: { current: string[] };
+    let result: { current: readonly string[] };
     await act(async () => {
       const r = renderHook(() => useTables(mockDs, ''));
       result = r.result;
@@ -31,7 +31,7 @@ describe('useTables', () => {
     const mockDs = {} as Datasource;
     mockDs.fetchTables = jest.fn((db: string) => Promise.resolve(['a', 'b']));
 
-    let result: { current: string[] };
+    let result: { current: readonly string[] };
     await act(async () => {
       const r = renderHook(() => useTables(mockDs, 'db'));
       result = r.result;