Fix ugly looking navigation on mobile #2823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm sure there are very few people looking at ClickHouse docs on mobile... never the less, the secondary (docs) navigation bar looks horrible on mobile:
This PR adds custom React components
Hamburger
,HamburgerMenu
andMobileMenu
(grouped underDocsCategoryMobileNav
) such that the secondary menu acts in a similar way to the primary menu (displays a burger menu and navigation overlay for smaller screen sizes).Result
Still to do:
dropdownCategories
insrc/theme/NavBar/Content/index.js
to it's own config file, accessible by this new component.Checklist