Apache Spark - Docs refactoring #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentsiLeviav
requested review from
kitop and
a team
and removed request for
a team
mshustov
requested review from
mzitnik and
laeg
and removed request for
kitop and
a team
mshustov
reviewed
Nov 18, 2024
| import TOCInline from '@theme/TOCInline'; | ||
|
|
||
| # Spark JDBC | ||
| One of the most used data sources supported by Spark is JDBC. |
There was a problem hiding this comment.
Do we need to provide any specific recommendations for the JDBC driver version?
There was a problem hiding this comment.
Do you have something specific version in mind?
@mzitnik is there a specific version we recommend on?
There was a problem hiding this comment.
@mshustov did you meant what version of ClickHouse JDBC we should recommend?
There was a problem hiding this comment.
did you meant what version of ClickHouse JDBC we should recommend?
yes
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
| The above examples demonstrate SparkSQL queries, which you can run within your application using any API—Java, Scala, PySpark, or shell. | ||
|
|
||
|
|
||
| ## Supported Data Types |
There was a problem hiding this comment.
could you extend the docs with the following sections:
- configuration options
- adjusting clickhouse settings (if possible, see Spark: Support read with settings spark-clickhouse-connector#367)
- logging
…connector.md Co-authored-by: Mikhail Shustov <[email protected]>
…connector.md Co-authored-by: Mikhail Shustov <[email protected]>
mzitnik
reviewed
Nov 20, 2024
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Show resolved
Hide resolved
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
| :::important | ||
| It's essential to include the [clickhouse-jdbc JAR](https://mvnrepository.com/artifact/com.clickhouse/clickhouse-jdbc) with the "all" classifier, | ||
| as the connector relies on [clickhouse-http](https://mvnrepository.com/artifact/com.clickhouse/clickhouse-http-client) and [clickhouse-client](https://mvnrepository.com/artifact/com.clickhouse/clickhouse-client) —both of which are bundled in clickhouse-jdbc:all. | ||
| Alternatively, you can add [clickhouse-client JAR](https://mvnrepository.com/artifact/com.clickhouse/clickhouse-client) and [clickhouse-http](https://mvnrepository.com/artifact/com.clickhouse/clickhouse-http-client) individually if you prefer not to use the full JDBC package. |
There was a problem hiding this comment.
IMO, giving two many alternatives can cause confusion.
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Outdated
Show resolved
Hide resolved
docs/en/integrations/data-ingestion/apache-spark/spark-native-connector.md
Show resolved
Hide resolved
mzitnik
approved these changes
Nov 20, 2024
mshustov
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our effort to improve Spark's documentation, this PR includes: