-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the GNKI tools and unit testing #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The algorithm looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! A couple questions: there are a few places with warnings saying certain lines are not covered by the tests, is that normal? I was also curious what ekp.verbose means? Is this something all the algorithms have?
This means that we added some new lines of code that are untested - we require ~90% of the new code to be covered as a soft-rule so we can add a couple more tests to cover anything important that was missed
Yes, if we add By the looks of it, I shall
...Docs now fail due to different environment issue.
|
All resolved - merging on tests passing and docs building |
Purpose
Closes #404
Closes #405
Closes #406
Coauthored by @rgjini
Content
MISC
deepcopy(Unscented(..))
processes when reusing them as they store a history internallynameof(typeof(X)) == name
should beSymbol(name)
. Replaced all cases withisa(X,name)
github-actions
where old packages are loaded instead of new ones, and resolves a related docs issueExample output: Sinusoid
N_ens=10
,N_iter=5
Ran defaults with
timestep = 1
i.e.
and with localization + accelerator,
timestep =1
"bells and whistles"