Remove CUDA from the test extras #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are still pretty slow, but I've got some ideas on how we can improve things. |
|
This should at least improve code loading time when running ClimaCore's test suite (it does seem to start much more quickly with |
Sbozzolo
approved these changes
Jun 10, 2024
|
I'm going to peel some pieces off from this.. |
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
2 times, most recently
from
8f2012e
to
0c1e5b5
Compare
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
3 times, most recently
from
bc52c60
to
bcecc63
Compare
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
from
bcecc63
to
cf36886
Compare
|
This PR is not ideal in that it uses That said, this does remove CUDA from the test environment. |
|
If you are not using macros from CUDA, you can access it with |
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
from
cf36886
to
7d6d846
Compare
Sbozzolo
approved these changes
Jun 20, 2024
Sbozzolo
reviewed
Jun 20, 2024
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
6 times, most recently
from
db90343
to
c5a01be
Compare
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
from
c5a01be
to
5ed9017
Compare
wip Use get_extension instead of eval-parse Add composed function stencil benchmark
charleskawczynski
force-pushed
the
ck/test_rm_cuda
branch
from
5ed9017
to
efe07b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes CUDA from the test environment.
I did comment out
Operators/spectralelement/opt.jlof runtests.jl (it's still run on buildkite), due to aviatesk/JET.jl#602.I think soon we'll split off our tests into
runtests_opt.jlthat performs all allocation, flop-counting, and inference tests.runtests_benchmark.jlthat performs all benchmarksruntests_convergence.jlthat performs all convergence tests(#1784)