Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Fix Lilit trait gain EoC #79404

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 28, 2025

Summary

Bugfixes "[Xedra Evolved] Fix Lilit trait gain EoC"

Purpose of change

It was pointed out that the lilit trait gain EoC requires you to be outdoors at sunset to turn on, meaning if you slept through sunset it would never fire unless you were specifically outside at sunset.

Describe the solution

Remove the check for being outdoors and only check for sunset.

Make sure the actual trait-gain EoC only fires at night.

Move the rate limiter check to the active effect, so if your timer runs out in the middle of the night you can gain powers the rest of the night.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jan 28, 2025
@github-actions github-actions bot requested a review from Maleclypse January 28, 2025 22:29
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 28, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 29, 2025
@GuardianDll GuardianDll merged commit a96bf09 into CleverRaven:master Jan 29, 2025
27 of 28 checks passed
@Standing-Storm Standing-Storm deleted the lilit-fix branch January 29, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants