-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapters are Character-mapped for unique books #79388
Chapters are Character-mapped for unique books #79388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the newly added generic
field in .md somewhere
More importantly, I'm not very familiar with our save handling, but the lack of explicit de-/serialization of the newly added Character::book_chapters
makes me think that this info would be lost after a save-load cycle? Can you please double-check that this part works?
Doesn't this still result in the linked issue being present for generic books? |
34b07d3
to
1b8270a
Compare
1b8270a
to
4e592a5
Compare
So I've fixed:
Great reviews, thanks. Double-check if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh.. do i need to press this approve button here? Still not quite sure how github reviews work, apologies
-instead of item instances mapping character->chapter count -"generic" books keep original chapter read behavior and cannot be copied, books with chapters now can
4e592a5
to
c21b37d
Compare
Summary
Bugfixes "chapters are character-mapped for unique books"
Purpose of change
Closes #77920
As explained in above issue, books can be copied indefinitely for infinite fun.
Describe the solution
Chapters read for each book itype are mapped per-Character instead of per-item unless
"generic": true
is added to a book specifying it as a type of book rather than a specific title (e.g.book of essays
)Describe alternatives you've considered
Testing
Read a copy of Dune, noted that another copy had same "chapters read"
Read a (generic = true) Playboy until all the charges were gone, noted a new copy had 4 chapters still left
Read a manual to make sure it still worked
Additional context
Not that it explains much, but you can see the copies of Dune I've read have the same chapters read and the other generic books don't: