Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fully walled-in safe from one of the banks. #79385

Conversation

SariusSkelrets
Copy link
Contributor

Summary

Bugfixes "remove the fully walled-in safe from one of the banks"

Purpose of change

what is that doing in there

There's no hidden wall, no non-destructive way to reach that safe, yet it's there for some unknown reason.

The safes will be where they belong.

Describe the solution

Remove that random safe and only that one.

Describe alternatives you've considered

Leave it in, because we all know that banks hide your money outside of their vaults.

Testing

fixed safe

Additional context

The other bank doesn't have that issue.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 27, 2025
@RenechCDDA
Copy link
Member

RenechCDDA commented Jan 27, 2025

Prior to #77459 it actually chance-based to have a door into the room. Removal of any entry seems to have been unintentional.

image

image

There's usually some money outside the vault, for meeting day-to-day obligations. The safest place to store it is in its own safe, of course.

The proper way to do this with current mapgen is probably a nest, instead of random chance for one (or more) of the walls being a door.

@SariusSkelrets
Copy link
Contributor Author

I'll close this PR. It'll be simpler to re-add the lost door in another PR

@SariusSkelrets SariusSkelrets deleted the Safes_go_in_bank_vaults_not_in_bank_walls branch January 27, 2025 23:27
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants