Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boards and amenities to NPC faction camps #79367

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

There's some minor things that have been troubling me with NPC faction camps. How do they... work? None of them have boards, none of them have obvious water sources. You need a board, and you need a water source. So where are they?

Describe the solution

Add the boards and add the water sources, as appropriate. Lumbermill got a water pump, as it's a rural location. Refugee center got a near-copy of the sink with some flavor added (still works as a water source). Exodii got skipped for water sources because they have a pond. Pretty much everyone who should have boards got boards.

Godco was actually well suited and had provisions for both already so got no changes.

This PR is only aimed at vanilla camps. Mods should do as they please.

Describe alternatives you've considered

I considered adding copies of the board furniture too, which were more suited to individual locations. But I guess a bulletin board is a universal enough form of human organization that it didn't feel too out of place anywhere.

Testing

Game loads, newly spawned specials have the new mapgen

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 27, 2025
@RenechCDDA
Copy link
Member Author

Huh, no hope overrides the palette. Okay... I guess we just add it there too.

@RenechCDDA
Copy link
Member Author

...and unlock their gate too, like 7a42024

@RenechCDDA RenechCDDA force-pushed the faction_camp_amenities branch from 691c620 to 2cd37aa Compare January 27, 2025 19:15
@github-actions github-actions bot added Mods: No Hope Relating to the mod No Hope BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 27, 2025
@Maleclypse Maleclypse merged commit 9001cba into CleverRaven:master Jan 28, 2025
28 checks passed
@RenechCDDA RenechCDDA deleted the faction_camp_amenities branch January 28, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: No Hope Relating to the mod No Hope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants