Skip to content

Commit

Permalink
Merge pull request #140 from Clever/INFRANG-6435
Browse files Browse the repository at this point in the history
updates to reusable-auto-approve-merge and reusable-notify-ci-status.yml
  • Loading branch information
tnsardesai authored Sep 18, 2024
2 parents f358691 + 703c10b commit aabd13c
Show file tree
Hide file tree
Showing 9 changed files with 36,139 additions and 8,542 deletions.
16 changes: 12 additions & 4 deletions .github/actions/notify-ci-status-action/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
After any changes to the actions `index.js` file, re-compile the index.js file with: `npm run build`
# Notify CI status action

- this pulls in the `node_modules` ahead of time to prevent version/system issues
- according to [Github docs](https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github): `Checking in your node_modules directory can cause problems. As an alternative, you can use a tool called @vercel/ncc to compile your code and modules into one file used for distribution.`
This github action is used to notify users in slack about a CI failure

Commit the updated `index.js` and the `dist/index.ts`.
## Developing

- Make changes to the code as needed.
- Make sure you run `npm install` and that a `node_modules` directory exists.
- `npm run build` to compile changes. It used `ncc` as [github recommends]((https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github)) us to not merge the `node_modules`.
- Commit all the changes but make sure that `node_modules` is not accidentally commited.

## Testing

To test this action make sure to update the job in [../../workflows/reusable-notify-ci-status.yml](../../workflows/reusable-notify-ci-status.yml) to point to the development branch. And then also make sure to point it back to master after testing
2 changes: 1 addition & 1 deletion .github/actions/notify-ci-status-action/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ outputs:
messageTS:
description: 'The slack message TS'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
Loading

0 comments on commit aabd13c

Please sign in to comment.