-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #140 from Clever/INFRANG-6435
updates to reusable-auto-approve-merge and reusable-notify-ci-status.yml
- Loading branch information
Showing
9 changed files
with
36,139 additions
and
8,542 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,14 @@ | ||
After any changes to the actions `index.js` file, re-compile the index.js file with: `npm run build` | ||
# Notify CI status action | ||
|
||
- this pulls in the `node_modules` ahead of time to prevent version/system issues | ||
- according to [Github docs](https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github): `Checking in your node_modules directory can cause problems. As an alternative, you can use a tool called @vercel/ncc to compile your code and modules into one file used for distribution.` | ||
This github action is used to notify users in slack about a CI failure | ||
|
||
Commit the updated `index.js` and the `dist/index.ts`. | ||
## Developing | ||
|
||
- Make changes to the code as needed. | ||
- Make sure you run `npm install` and that a `node_modules` directory exists. | ||
- `npm run build` to compile changes. It used `ncc` as [github recommends]((https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github)) us to not merge the `node_modules`. | ||
- Commit all the changes but make sure that `node_modules` is not accidentally commited. | ||
|
||
## Testing | ||
|
||
To test this action make sure to update the job in [../../workflows/reusable-notify-ci-status.yml](../../workflows/reusable-notify-ci-status.yml) to point to the development branch. And then also make sure to point it back to master after testing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.