add felt op #45
Merged
add felt op #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
requested changes
Jun 20, 2024
ClementWalter
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add felt-compatible multiplication and addition
Time spent on this PR: 20 mins
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #41
What is the new behavior?
Implemented ADD_FELT and MUL_FELT functions from already existing modAdd and modMul.
On google sheets, ADD_FELT("3618502788666131213697322783095070105623107215331596699973092056135872020481";1) returns 0x1.
ADD and MUL are already used by google sheets for regular (non modular) operations.