Feature/12 disabled chapters (#20)

* Added check to remove disabled chapters from the 'Applicable Standards/Guidelines' table.

* Added another check to look for notes for a given chapter.

* Added check to remove standards/guideline header if disabled or no notes.

* Updated tests for disabled chapters. Removed video generation to speed up CI.

cypress.json

@@ -1,6 +1,6 @@
 {
   "baseUrl": "http://localhost:10001",
-  "video": true,
+  "video": false,
   "videosFolder": "cypress/results",
   "reporter": "junit",
   "reporterOptions": {

cypress/integration/report.test.js

@@ -245,8 +245,22 @@ describe("Report", () => {
 
     cy.get("button").contains("View Report").click();
 
+    cy.get(".applicable-standards-guidelines-table").should(
+      "not.contain",
+      "Chapter 4: Hardware"
+    );
+
+    cy.get("#hardware-editor").should("not.exist");
+
     cy.get("#hardware-editor + table").should("not.exist");
 
+    cy.get(".applicable-standards-guidelines-table").should(
+      "contain",
+      "Chapter 5: Software"
+    );
+
+    cy.get("#software-summary").should("exist");
+
     cy.get("#software-summary + table").should("exist");
   });
 });

src/components/report/ReportChapter.svelte

@@ -43,7 +43,9 @@
   }
 </style>
 
-<HeaderWithAnchor id={chapterId} level=3 {download}>{chapter.label}</HeaderWithAnchor>
+{#if !$evaluation['chapters'][chapterId]['disabled'] || $evaluation['chapters'][chapterId]['notes']}
+  <HeaderWithAnchor id={chapterId} level=3 {download}>{chapter.label}</HeaderWithAnchor>
+{/if}
 
 {#if $evaluation['chapters'][chapterId]['notes']}
   <div id="{chapterId}-notes" class="chapter-notes-section">

src/components/report/ReportHeader.svelte

@@ -97,7 +97,7 @@
       {#each catalog.standards as standard }
         <tr>
           <td><a href="{standard.url}" target="_blank">{standard.label}<span class="visuallyhidden"> (opens in a new window or tab)</span></a></td>
-          <td>{@html standardsIncluded($evaluation.catalog, standard.chapters)}</td>
+          <td>{@html standardsIncluded($evaluation.catalog, standard.chapters, $evaluation.chapters)}</td>
         </tr>
       {/each}
     </tbody>

src/utils/getCatalogItems.js

@@ -10,11 +10,20 @@ export function getCatalogChapter(catalogName, chapterId) {
   }
 }
 
-export function standardsIncluded(catalogName, standardChapters) {
+export function standardsIncluded(
+  catalogName,
+  standardChapters,
+  evaluationChapters
+) {
   const result = [];
   for (const standardChapter of standardChapters) {
     const catalogChapter = getCatalogChapter(catalogName, standardChapter);
-    result.push(`<li>${catalogChapter.label}</li>`);
+    if (
+      !evaluationChapters[standardChapter].disabled ||
+      evaluationChapters[standardChapter].notes
+    ) {
+      result.push(`<li>${catalogChapter.label}</li>`);
+    }
   }
   return sanitizeHtml(`<ul>${result.join("")}</ul>`);
 }