Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad link #25

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix bad link #25

merged 2 commits into from
May 22, 2024

Conversation

TheBoatyMcBoatFace
Copy link
Member

The /join page went to BASE_URL/join, a 404, and not BASE_URL/ca-jekyll-vanilla/join/. This fixes that.

The /join page went to BASE_URL/join, a 404, and not BASE_URL/ca-jekyll-vanilla/join/. This fixes that.

Signed-off-by: Bentley Hensel <[email protected]>
Copy link

Pa11y testing results
> pa11y-ci:sitemap
> pa11y-ci --sitemap http://127.0.0.1:4000/ca-jekyll-vanilla/sitemap.xml --sitemap-find https://civicactions.github.io --sitemap-replace http://127.0.0.1:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 5 URLs:
 > http://localhost:4000/ca-jekyll-vanilla/2021/04/23/welcome-to-jekyll.html - 1 errors
 > http://localhost:4000/ca-jekyll-vanilla/about/ - 2 errors
 > http://localhost:4000/ca-jekyll-vanilla/ - 1 errors
 > http://localhost:4000/ca-jekyll-vanilla/join/ - 2 errors
 > http://localhost:4000/ca-jekyll-vanilla/search/ - 2 errors

Errors in http://localhost:4000/ca-jekyll-vanilla/2021/04/23/welcome-to-jekyll.html:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

Errors in http://localhost:4000/ca-jekyll-vanilla/about/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • Duplicate id attribute value "main-content" found on the web page.

   (#main-content)

   <main class="usa-layout-docs usa-layout-docs__main usa-prose"
   id="main-content"> <h1>About</...</main>

Errors in http://localhost:4000/ca-jekyll-vanilla/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

Errors in http://localhost:4000/ca-jekyll-vanilla/join/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • Duplicate id attribute value "main-content" found on the web page.

   (#main-content)

   <main class="usa-layout-docs usa-layout-docs__main usa-prose"
   id="main-content"> <h1>Join</h...</main>

Errors in http://localhost:4000/ca-jekyll-vanilla/search/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • Duplicate id attribute value "main-content" found on the web page.

   (#main-content)

   <main class="usa-layout-docs usa-layout-docs__main usa-prose"
   id="main-content"> <h1>Search<...</main>

✘ 0/5 URLs passed

Copy link

github-actions bot commented May 22, 2024

Cypress Test Results

4 tests   4 ✔️  4s ⏱️
6 suites  0 💤
3 files    0

Results for commit ee7e34f.

♻️ This comment has been updated with latest results.

index.markdown Outdated Show resolved Hide resolved
Signed-off-by: Bentley Hensel <[email protected]>
Copy link

Pa11y testing results
> pa11y-ci:sitemap
> pa11y-ci --sitemap http://127.0.0.1:4000/ca-jekyll-vanilla/sitemap.xml --sitemap-find https://civicactions.github.io --sitemap-replace http://127.0.0.1:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 5 URLs:
 > http://localhost:4000/ca-jekyll-vanilla/2021/04/23/welcome-to-jekyll.html - 1 errors
 > http://localhost:4000/ca-jekyll-vanilla/about/ - 2 errors
 > http://localhost:4000/ca-jekyll-vanilla/ - 3 errors
 > http://localhost:4000/ca-jekyll-vanilla/join/ - 2 errors
 > http://localhost:4000/ca-jekyll-vanilla/search/ - 2 errors

Errors in http://localhost:4000/ca-jekyll-vanilla/2021/04/23/welcome-to-jekyll.html:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

Errors in http://localhost:4000/ca-jekyll-vanilla/about/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • Duplicate id attribute value "main-content" found on the web page.

   (#main-content)

   <main class="usa-layout-docs usa-layout-docs__main usa-prose"
   id="main-content"> <h1>About</...</main>

Errors in http://localhost:4000/ca-jekyll-vanilla/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 4.5:1, but text in this element has a contrast
   ratio of 1.14:1. Recommendation:  change background to #767676.

   (html > body > section:nth-child(6) > div > div > div:nth-child(2) > div >
   table > tbody > tr > td:nth-child(1))

   <td>Everyone is welcome. [Learn how...</td>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 4.5:1, but text in this element has a contrast
   ratio of 1.14:1. Recommendation:  change background to #767676.

   (html > body > section:nth-child(6) > div > div > div:nth-child(2) > div >
   table > tbody > tr > td:nth-child(2))

   <td>relative_url }}) to CivicAction...</td>

Errors in http://localhost:4000/ca-jekyll-vanilla/join/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • Duplicate id attribute value "main-content" found on the web page.

   (#main-content)

   <main class="usa-layout-docs usa-layout-docs__main usa-prose"
   id="main-content"> <h1>Join</h...</main>

Errors in http://localhost:4000/ca-jekyll-vanilla/search/:

 • Elements must only use allowed ARIA attributes
   (https://dequeuniversity.com/rules/axe/4.2/aria-allowed-attr?application=axeAPI)

   (html > body > footer > div > section > div > div:nth-child(2))

   <div class="usa-identifier__identity" aria-label="Agency description"> <p
   class="usa-identifi...</div>

 • Duplicate id attribute value "main-content" found on the web page.

   (#main-content)

   <main class="usa-layout-docs usa-layout-docs__main usa-prose"
   id="main-content"> <h1>Search<...</main>

✘ 0/5 URLs passed

@dmundra dmundra merged commit 49482b1 into main May 22, 2024
8 checks passed
@dmundra dmundra deleted the bh-patch-1 branch May 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants