Test on real data #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnattino
commented
Jan 15, 2025
| @@ -51,24 +51,16 @@ get_osm_river <- function(river_name, bb, crs) { | |||
| river_centerline <- osmdata_as_sf("waterway", "river", bb) | |||
| river_centerline <- river_centerline$osm_multilines |> | |||
| filter(.data$name == river_name) |> | |||
| st_filter(sf::st_as_sfc(bb), .predicate = sf::st_intersects) |> | |||
There was a problem hiding this comment.
As also noticed in CRiSp, the Overpass API query for the river centerline now returns an additional branch of the Dambovita, not sure why, since it does not intersects the bounding box...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
I have also resized the packaged data, limiting the street network to the city boundary. The main reason is that in the outskirt of Bucharest I have found one motorway link that would give rise to a self-intersecting-yet-perfectly-valid stroke, but which would then be tricky to validate as implemented in the test (i.e. using
sf::st_containswould not identify the constituting initial edges due to the self-intersection). Since this is some sort of an edge case which would only make the validation trickier without bringing more insight into the well-functioning of rcoins, I have decided for the easy fix i.e. to modify the dataset. As a derived benefit, the data script is also more concise (the "buffer" functionality was imported from CRiSp but not really needed).