Package data #24
Merged
Package data #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Nice way to serialise data and include it as part of the package! Since this is actually more or less the same data as in testing, maybe this can also replace the testdata as well? |
Yes, I think so, because the data is used in the vignettes, on the user side, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initialised the package data with the city boundary and a couple of other layers of Bucharest. The data is stored as a list with a named element for each layer we want to store (e.g.,
bucharest$boundaryfor the layer I added). We can add other layers to that list via the data generation script indata_raw/bucharest.Rwhich will update the package data indata/bucharest.rdawhen it is run.If the list becomes too big with all the layers, we can replace the list with separate
rdafiles.