Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJDH-718 | Fix Kesäseteli's frontend docker developing, hot reload & permissions #3604

Merged
merged 1 commit into from
Nov 28, 2024
Merged

YJDH-718 | Fix Kesäseteli's frontend docker developing, hot reload & permissions #3604

merged 1 commit into from
Nov 28, 2024
+35 −3

Conversation

karisal-anders
Copy link
Collaborator

@karisal-anders karisal-anders commented Nov 26, 2024 •
edited
Loading

Description ✨

fix: kesaseteli frontend docker developing, hot reload & permissions

  • added WATCHPACK_POLLING=true by default so hot reload should work
    for most platforms out of the box now (e.g. on Windows 11 + Docker
    Desktop + WSL2 with the files volume mapped from the host filesystem
    to the docker container hot reload now works)
  • made sure frontend/Dockerfile-localdevelopment sets up the
    project's .next directory so that the express server can access its
    files

refs YJDH-718 (making kesaseteli frontend docker development usable)

Issues 🐛

YJDH-718

Testing ⚗️

Screenshots 📸

Additional notes 🗒️

Permission problems using docker compose -f compose.handler.yml up --build before/during this PR development, but not after this PR:

             triggerUncaughtException(err, true /* fromPromise */);
             ^

 [Error: EACCES: permission denied, open '/app/kesaseteli/youth/.next/package.json'] {
   errno: -13,
 node:internal/process/promises:288
   code: 'EACCES',
             triggerUncaughtException(err, true /* fromPromise */);
   syscall: 'open',
             ^
   path: '/app/kesaseteli/youth/.next/package.json'

 }
 [Error: EACCES: permission denied, open '/app/kesaseteli/handler/.next/package.json'] {

   errno: -13,
 Node.js v18.20.4
   code: 'EACCES',
 error Command failed with exit code 1.
   syscall: 'open',

@karisal-anders
fix: kesaseteli frontend docker developing, hot reload & permissions
49c0654 
 - added `WATCHPACK_POLLING=true` by default so hot reload should work
   for most platforms out of the box now (e.g. on Windows 11 + Docker
   Desktop + WSL2 with the files volume mapped from the host filesystem
   to the docker container hot reload now works)
 - made sure `frontend/Dockerfile-localdevelopment` sets up the
   project's `.next` directory so that the express server can access its
   files

refs YJDH-718 (making kesaseteli frontend docker development usable)
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
11 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
8.8% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
58 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
33.3% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh-tet-shared'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3604.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr3604.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3604.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3604.dev.hel.ninja 🚀🚀🚀

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://yjdh-tet-youth-ui-pr3604.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://yjdh-tet-admin-ui-pr3604.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3604.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr3604.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3604.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3604.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3604.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3604.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3604.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr3604.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr3604.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr3604.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr3604.dev.hel.ninja 😆🎉🎉🎉

@karisal-anders karisal-anders merged commit 508bad1 into main Nov 28, 2024
194 checks passed
@karisal-anders karisal-anders deleted the YJDH-718-fix-ks-frontend-docker branch November 28, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karisal-anders @terovirtanen @sirtawast