Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cookiehub destroying csrf token #1598

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: cookiehub destroying csrf token #1598

merged 1 commit into from
Jan 10, 2025

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Jan 10, 2025 •
edited
Loading

🛠️ Changelog

  • Fix: cookiehub "Only mandatory cookies" button destroying our cookies including csrftoken leading to all backend requests breaking.

🧪 Test plan

  • Manual testing: check that no matter the selection in the cookie consent backend requests don't break. Requires using a frontend query / mutation (not SSR / page load) ex. check your own reservations and switch between tabs.
  • Manual testing: confirm it works in production.

🎫 Tickets

  • TILA-####

@joonatank joonatank force-pushed the fix-cookiehub-destroying-csrftoken branch from 642bafa to a3d3f0b Compare January 10, 2025 08:54
@joonatank joonatank changed the title wip: fix: cookiehub destroying csrf token fix: cookiehub destroying csrf token Jan 10, 2025
@joonatank joonatank force-pushed the fix-cookiehub-destroying-csrftoken branch from a3d3f0b to 36f6f16 Compare January 10, 2025 09:07
@joonatank joonatank marked this pull request as ready for review January 10, 2025 09:09
@joonatank joonatank force-pushed the fix-cookiehub-destroying-csrftoken branch from 36f6f16 to cc8a23a Compare January 10, 2025 09:10
@joonatank joonatank merged commit 9fec92f into main Jan 10, 2025
8 checks passed
@joonatank joonatank deleted the fix-cookiehub-destroying-csrftoken branch January 10, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@vincit-matu vincit-matu Awaiting requested review from vincit-matu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vergama