Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new login params #1432

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add new login params #1432

merged 3 commits into from
Nov 21, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Nov 14, 2024

🛠️ Changelog

  • lang param can be used to set keycloak UI language from the frontend
  • ui parameter can be used to select which UI is making the login (customer or admin).
    • If customer, hints to use suomi.fi login
    • if admin, currently does nothing
    • If hint is wrong, should display the login selection as normal
    • Currently this is not working in Helsinki tunnistus, maybe it will be fixed at some point?

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added the improvement Improves an existing feature label Nov 14, 2024
@matti-lamppu matti-lamppu self-assigned this Nov 14, 2024
@City-of-Helsinki City-of-Helsinki deleted a comment from github-actions bot Nov 14, 2024
@matti-lamppu matti-lamppu marked this pull request as ready for review November 14, 2024 12:56
@matti-lamppu matti-lamppu force-pushed the login-params branch 5 times, most recently from 74e84d6 to 6226111 Compare November 19, 2024 11:09
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.5% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@matti-lamppu matti-lamppu merged commit 2779a79 into main Nov 21, 2024
4 of 5 checks passed
@matti-lamppu matti-lamppu deleted the login-params branch November 21, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants