Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inactive users #1431

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Handle inactive users #1431

merged 2 commits into from
Nov 21, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Nov 14, 2024 •
edited
Loading

🛠️ Changelog

  • Now if the user logging in is inactive, login fails and redirects to a frontend error page (currently missing)
  • Also logout inactive users during currentUser query

🧪 Test plan

  • Automated tests

🚧 Dependencies

🎫 Tickets

@matti-lamppu matti-lamppu self-assigned this Nov 14, 2024
@matti-lamppu matti-lamppu added fix Fixes a bug improvement Improves an existing feature and removed fix Fixes a bug labels Nov 14, 2024
@matti-lamppu matti-lamppu changed the title Add INACTIVE_USER_URL settings pointing to frontend error page Handle inactive users Nov 14, 2024
@matti-lamppu matti-lamppu marked this pull request as ready for review November 14, 2024 10:55
@matti-lamppu matti-lamppu force-pushed the deactivated-account-page branch from c8fc567 to 627e6f7 Compare November 14, 2024 12:58
@matti-lamppu matti-lamppu force-pushed the deactivated-account-page branch 5 times, most recently from 0c28e42 to 4960a72 Compare November 19, 2024 11:09
@matti-lamppu matti-lamppu force-pushed the deactivated-account-page branch from 4960a72 to c392dc5 Compare November 21, 2024 08:40
@matti-lamppu matti-lamppu enabled auto-merge (rebase) November 21, 2024 08:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matti-lamppu matti-lamppu merged commit 8ca37a7 into main Nov 21, 2024
5 checks passed
@matti-lamppu matti-lamppu deleted the deactivated-account-page branch November 21, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama vergama approved these changes

Assignees

@matti-lamppu matti-lamppu

Labels
improvement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta