New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seasonal Reservation Emails #1468

Open

ranta wants to merge 22 commits into main from email-cancel-seasonal

Collaborator

ranta commented Dec 12, 2024 •

edited by jira bot

Loading

🛠️ Changelog

Add a bunch of new emails when seasonal reservations/application sections/reservation series get modified/cancelled/rejected

🧪 Test plan

Automated tests

🚧 Dependencies

None

🎫 Tickets

TILA-3668

ranta requested review from vergama and matti-lamppu

December 12, 2024 03:01

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/admin/email_template/forms.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/template_context/application.py Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/sending.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/main.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/main.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/main.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/main.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/main.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/template_context/application.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/admin/email_template/forms.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/template_context/reservation.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/main.py Outdated Show resolved Hide resolved

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/typing.py Outdated Show resolved Hide resolved

ranta added 11 commits

December 12, 2024 15:16


          Alphabetize email types, contexts and send methods

cdcc25a

- Enhance code, readability maintainability and developer viewing pleasure by incorporating structured visual delineation through section separators and streamlined formatting (add pretty dividers).


          Rename booking_number variable name to reservation_id in Emails

222628f

- Removes a second name for the same value


          Refactor email sending tasks convert EmailData into a dataclass

ae8fb62


          Email: Simplify tester form initial data

40de206


          Email: Simplify render tests with get_mock_data

593d659


          Email: Add emails for SEASONAL_RESERVATION_REJECTED_SINGLE

e0029bf


          Email: Add emails for SEASONAL_RESERVATION_CANCELLED_SINGLE

a22b7c3


          Email: Add emails for SEASONAL_RESERVATION_MODIFIED_SINGLE

f028b8c


          Email: Add emails for SEASONAL_RESERVATION_MODIFIED_SERIES

037a618


          Email: Add emails for SEASONAL_RESERVATION_REJECTED_SERIES

1172c5f


          Email: Add emails for APPLICATION_SECTION_CANCELLED

d7cfc74

matti-lamppu reviewed

View reviewed changes

tilavarauspalvelu/admin/email_template/forms.py Outdated Show resolved Hide resolved

ranta added 3 commits

December 12, 2024 15:39


          Email: Add emails for STAFF_NOTIFICATION_APPLICATION_SECTION_CANCELLED

9355a9f


          Fix incorrect usages of super()

d12f9cd


          Use only EmaiLData type argument in send_emails_in_batches_task

5555f7e

ranta added 5 commits

December 12, 2024 16:02


          Don't sent cancellation emails if Application status is not RESULTS_SENT

2d17d15


          Simplify checking if application section exists for reservation series

36b126c


          Move cancelled_reservation_series value to form and get_mock_data

3eb1017


          Fix incorrect text used in series rejected email

c4c860a


          Fix email typing issues

fd5b35d

ranta force-pushed the email-cancel-seasonal branch from bda927b to 7192542 Compare

December 12, 2024 18:05

ranta requested review from vergama and matti-lamppu

December 12, 2024 18:06

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/email/find_recipients.py Outdated Show resolved Hide resolved

ranta added 3 commits

December 13, 2024 16:38


          Fix sending section cancelled email to all reservation unit staff users

385aa3c


          Get seasonal email recipients from application instead of reservation

4cb26a5


          Get seasonal email recipient name from application, not reservation

32ddc13

ranta force-pushed the email-cancel-seasonal branch from 7192542 to 32ddc13 Compare

December 13, 2024 14:39

sonarcloud bot commented Dec 13, 2024

Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet