MVJ-421 Tasotarkistus Add New #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement the feature of adding tasotarkistus to a rent that previously does not have it.
The
old_dwellings_in_housing_companies_price_indexhas to be fetched from the database through the API, and the best way to implement this in the MVJ-UI is to create a new reducer for it. It should fetch the latest data from the DB when the LeaseListPage is opened. That data is used for adding a tasotarkistus for the rent.Currently, it cannot resolve the fetch, although it seems to be implemented the same way as reducers for VAT and service unit. The most likely cause is something missing in the viewset definition in the API.
These changes depend on these changes in the API: City-of-Helsinki/mvj#793