Sort radionbuttoninline field choices #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrinie-nc
reviewed
Nov 13, 2024
NC-jsAhonen
force-pushed
the
MVJ-189-company-first-in-applicant-type
branch
from
fb7737b to
16381f5
Compare
NC-jsAhonen
changed the title
src/application/helpers.ts
Outdated
| }; | ||
|
|
||
| export const getRadioButtonInlineFieldChoicesSorted = (field: FormField, choices: FormFieldChoice[]): FormFieldChoice[] => { |
There was a problem hiding this comment.
I would add a documentation comment here, saying what is the goal of the function in this case. Or maybe even better to rename the function to getRadioButtonApplicantFieldChoicesSorted, to make it clear from the outside that it is only intended for the applicant field and no other use cases.
juho-kettunen-nc
requested changes
Nov 14, 2024
|
Good idea to name the function with intention to make it expandable. |
juho-kettunen-nc
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the radiobuttoninline field is 'hakija', the choices will be sorted by value so that Yritys is first and Henkilö is last.