Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receivable types: fetch beyond page limit #534

Merged
merged 7 commits into from
Oct 21, 2024
Merged

receivable types: fetch beyond page limit #534

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eee152a
receivable types: fetch beyond page limit
NC-jsAhonen Oct 11, 2024
0d133e2
remove comment and format
NC-jsAhonen Oct 11, 2024
a129038
receivable types: sort by name
NC-jsAhonen Oct 16, 2024
652bc34
leasing invoicing receivalbe types: add null check to saga
NC-jsAhonen Oct 17, 2024
f2570aa
lease invoicing receivable types: safety cap for while loop iterations
NC-jsAhonen Oct 17, 2024
8a10018
lease invoicing receivable types: refine null check
NC-jsAhonen Oct 17, 2024
c86e1b3
create api response pagination
NC-jsAhonen Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/leaseCreateCharge/saga.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function* fetchReceivableTypesSaga(): Generator<any, any, any> {
switch (statusCode) {
case 200:
allReceivableTypes.push(...bodyAsJson.results);
nextUrl = bodyAsJson.next;
nextUrl = bodyAsJson.next || null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some value in bodyAsJson.next that is not the next URL, or already null if there are no more receivable types?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought the value is null already, if there's no more data coming from backend.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If what Juho says is correct then the or is a bit rendundant right?

break;

default:
Expand Down