fix intended use issue for readonly perms #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrinie-nc
requested review from
NC-jsAhonen,
robertrytovuori and
juho-kettunen-nc
henrinie-nc
force-pushed
the
MVJ-442-fix-intended-use-rendering-readonly
branch
from
82a0061 to
ed9129d
Compare
tried to render an object which is not possible as text.
henrinie-nc
force-pushed
the
MVJ-442-fix-intended-use-rendering-readonly
branch
from
ed9129d to
cc99912
Compare
field `note` was not showing up in edit mode for users that only had readonly perms for it
juho-kettunen-nc
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tried to render an object which is not possible as text.