-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mvj 370 cra to vite #514
Mvj 370 cra to vite #514
Conversation
Seems like JSX.Element expects a single child. React.ReactNode as a type for children did not work either. So I did it the alternative way and added fragments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly a lot of work gone into this. I went through commits 1 by 1 but couldn't find anything that I thought required fixing. Looks good!
The local
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would approve this at this point.
To add to the list of work to be done in the future
Externalised source mapping issues, such as
Module "source-map-js" has been externalized for browser compatibility. Cannot access "source-map-js.SourceMapConsumer" in client code. See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details. source-map-js:9:14
Firefox browser compatibility issues
Error: Not allowed to define cross-origin object as property on [Object] or [Array] XrayWrapper
Warning: Warning: MouseEvent.mozInputSource is deprecated. Use PointerEvent.pointerType instead.
HMR issues with Firefox when doing code changes:
ReferenceError: can't access lexical declaration 'LeasePage' before initialization
[hmr] Failed to reload /src/leases/components/LeasePage.tsx. This could be due to syntax errors or importing non-existent modules. (see errors above)
`
Those are configurable, did not change the defaults. Everyone could have their own specific config |
Would make sense to add subtasks from these findings |
Almost everything changed, and may not be perfect.
I suggest reviewing commit by commit, otherwise it might be a tad too massive.
This pull request mainly contains the following:
There's still additional work to be done: