invoice edit: fetch receivable types by lease's service unit #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrytovuori
approved these changes
Jun 28, 2024
NC-jsAhonen
deleted the
MVJ-371-receivable-types-filtered-by-lease-service-unit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, receivable types (saamislaji) were filtered by user's active service unit in Vuokraus => Laskutus tab, both in the invoice edit view and create new invoice view. However, they should be filtered by the current lease's service unit in order to make sure that it is not possible to give a receivable type for the lease's invoice that belongs to a wrong service unit.
Notice that saving the changes to the invoice does not work. That issue will be handled separately.