move service unit filter next to basic search in leases view #477
Conversation
robertrytovuori
commented
May 3, 2024
•
robertrytovuori
commented
| autoBlur | ||
| disableDirty | ||
| fieldAttributes={{ | ||
| label: 'Palvelukokonaisuus', |
There was a problem hiding this comment.
This label is repeated in many places, so it is recommended to use the enum in leases/enums.js
| @@ -236,6 +236,27 @@ class Search extends PureComponent<Props, State> { | |||
| /> | |||
| </Column> | |||
| </Row> | |||
| <SearchRow> | |||
| <SearchLabelColumn> | |||
| <SearchLabel>Palvelukokonaisuus</SearchLabel> | |||
There was a problem hiding this comment.
Could this be something like Suodata palvelukokonaisuuden mukaan, to distinguish from the top nav bar filter. Should this label be put on a separate line above the field, just like in other fields?
You could also add a visible label for the search field above in the same way with text something like Hae hakusanalla or something else.
There was a problem hiding this comment.
Headerissa voisi lukea Oma palvelukokonaisuus
Suodatuksessa voisi lukea Vuokrauspalvelu
|
|
src/components/table/TableFilters.js
Outdated
| @@ -33,6 +35,7 @@ const TableFilters = ({ | |||
| {!!filterOptions.length && | |||
| <p className='table__filters_filter-wrapper_title'>Suodatus</p> | |||
| } | |||
| {!!componentToRenderUnderLabel && componentToRenderUnderLabel} | |||
There was a problem hiding this comment.
I would suggest two possible options for renaming componentToRenderUnderLabel:
componentToRenderUnderTitle: The p element above is not a label but a title. I was a bit confused about where there should be a label.serviceUnitFilterComponent: Describes more clearly about what the component is. There are no other components to be rendered in this position, so I think it is fine to state it more explicitly what component is rendered there.
There was a problem hiding this comment.
Renamed it to componentToRenderUnderTitle. Though serviceUnitFilterComponent tells more in this use case, I still think the TableFilter component does not have to know what React component is being injected.
| @@ -105,7 +105,7 @@ class Search extends PureComponent<Props, State> { | |||
| newState.municipalityOptions = getFieldOptions(props.leaseAttributes, LeaseFieldPaths.MUNICIPALITY); | |||
| newState.tenantTypeOptions = getFieldOptions(props.leaseAttributes, LeaseTenantContactSetFieldPaths.TYPE, false); | |||
| newState.typeOptions = getFieldOptions(props.leaseAttributes, LeaseFieldPaths.TYPE); | |||
| newState.serviceUnitOptions = getFieldOptions(props.leaseAttributes, 'service_unit', true); | |||
| //newState.serviceUnitOptions = getFieldOptions(props.leaseAttributes, 'service_unit', true); | |||
There was a problem hiding this comment.
isSearchBasicMode method beginning on line 147 delete searchQuery.service_unit; needs to be added so that the detailed search view would not render when the service unit filter is being modified. Now it will render when the page is refreshed.
juho-kettunen-nc
deleted the
MVJ-218_move-service-unit-lease-filter-out-of-detailed-search
branch
