Mvj 177 footer links #130
Merged
Mvj 177 footer links #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/i18n/sv/common.json
Outdated
| @@ -355,7 +352,7 @@ | |||
| }, | |||
| "registerStatement": { | |||
| "label": "Registerbeskrivning", | |||
| "url": "#" | |||
| "url": "https://www.hel.fi/static/liitteet-2019/Kaupunginkanslia/Rekisteriselosteet/Kymp/Tonttien%20hankinnan%20ja%20luovutuksen%20asiakasrekisteri.pdf" | |||
There was a problem hiding this comment.
I think the swedish version link was posted to ticket a few minutes ago, so we can use that
src/i18n/sv/common.json
Outdated
| "linkedin": "Helsingfors stad på LinkedIn" | ||
| "customerService": { | ||
| "label": "Stadsmiljösektorns kundservice", | ||
| "url": "https://www.hel.fi/sv/stadsmiljo-och-trafik/stadsmiljosektorns-kundtjanst" | ||
| }, | ||
| "moveToTop": "Gå upp", | ||
| "accessabilityStatement": { |
There was a problem hiding this comment.
This isn't broken or part of the changes, but this variable name has a typo. Should be accessibilityStatement.
There was a problem hiding this comment.
@juho-kettunen-nc fixed, could yo ure-review?
juho-kettunen-nc
requested changes
Nov 26, 2024
juho-kettunen-nc
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.