-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web components package #928
base: master
Are you sure you want to change the base?
Conversation
I tried to remove node_modules and reinstall modules but it did not help. Maybe I have some version mismatch or something 🤔 |
I added a .js-postfix in a lit-module import in the storybook file to fix this. Somehow the lit-modules require the full path in imports 🤷 |
9a121e2
to
2100f90
Compare
b2de6d4
to
515f506
Compare
3411984
to
f5516ac
Compare
Storybook uses react
32d0252
to
d1ca8da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's getting there! 💪
"release": "lerna publish from-package --yes", | ||
"update-versions": "lerna version --exact --no-git-tag-version --no-push --amend --yes" | ||
"start:web-component": "lerna run --scope hds-web-components start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there are two similar commands with almost identical names start:web-components
and start:web-component
. Should start:web-component
to be removed?
Description
Related Issue
Motivation
How Has This Been Tested?
Unfinished tasks:
Demo