HAI-1527 Audit logging for permission updates #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvidian
force-pushed
the
HAI-1527/audit-logs-for-changing-permissions
branch
2 times, most recently
from
337eccf to
3a565a1
Compare
corvidian
force-pushed
the
HAI-1527/edit-api-for-access-rights
branch
from
21d2fc4 to
390d7be
Compare
corvidian
force-pushed
the
HAI-1527/audit-logs-for-changing-permissions
branch
from
3a565a1 to
9fc4e10
Compare
corvidian
force-pushed
the
HAI-1527/edit-api-for-access-rights
branch
from
390d7be to
eaebceb
Compare
corvidian
force-pushed
the
HAI-1527/audit-logs-for-changing-permissions
branch
from
9fc4e10 to
62351e3
Compare
corvidian
force-pushed
the
HAI-1527/audit-logs-for-changing-permissions
branch
from
62351e3 to
b8c53db
Compare
pitkni
reviewed
Aug 31, 2023
| import org.springframework.transaction.annotation.Transactional | ||
|
|
||
| @Service | ||
| class HankeKayttajaLoggingService(private val auditLogService: AuditLogService) { |
There was a problem hiding this comment.
Are all these functions unit tested?
There was a problem hiding this comment.
Oops, some of these were copied over and unchanged. Removing them.
I added unit tests for the ones that are still in use.
|
Kudos, SonarCloud Quality Gate passed! |
pitkni
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add audit logging for permission updates
Jira Issue:
Type of change
Instructions for testing
Change permissions, check audit logs in DB.
Checklist:
or other location: