Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9488 Drupal 10.2 #671

Merged
merged 29 commits into from
Jan 12, 2024
Merged

UHF-9488 Drupal 10.2 #671

merged 29 commits into from
Jan 12, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Dec 21, 2023

UHF-9488

What was done

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Fetch all changes from repository and change to UHF-9488_drupal-10.2 branch
    • git fetch --all
    • git checkout UHF-9488_drupal-10.2
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9488_drupal-10.2 -W
  • Run make drush-updb drush-cr

How to test

  • Explore the site and make sure nothing's broken 😇
  • Check that code follows our standards

Other PRs

hyrsky and others added 20 commits December 18, 2023 15:45
…ue: https://www.drupal.org/i/3264573 will fail to apply in 4.1.8. This issue will be solved in UHF-9273.
@khalima khalima mentioned this pull request Dec 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (81be73a) 13.07% compared to head (b08dd6c) 13.07%.
Report is 6 commits behind head on main.

❗ Current head b08dd6c differs from pull request most recent head fd5aa82. Consider uploading reports for the commit fd5aa82 to get more accurate results

Files Patch % Lines
src/Menu/FilterDisabledTranslations.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #671   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
- Complexity      241      242    +1     
=========================================
  Files            28       28           
  Lines           941      941           
=========================================
  Hits            123      123           
  Misses          818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on rekry. 🚀

patches/3091246--allow-menu-tree-manipulators-alter.patch Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
…h would be presented to user in English, no matter which UI language have been selected. This patch will use the preferred admin pages language from current user or the interface language if preferred language is not set.
…as that will create a recursion when trying to flush caches.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima khalima merged commit 8a5b45f into main Jan 12, 2024
3 checks passed
@khalima khalima deleted the UHF-9488_drupal-10.2 branch January 12, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants