Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10773: Make the popular services templates reusable #1132

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 10, 2024

UHF-10773

What was done

  • Make the popular services templates reusable for Helsinki near you page purposes.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10773
  • Run make drush-cr

How to test

  • Make sure that the popular services paragraph still works normally and you can use it without any errors.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

@juho-lehmonen juho-lehmonen self-requested a review December 13, 2024 08:42
@teroelonen teroelonen marked this pull request as ready for review December 13, 2024 10:59
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1132/html_report/

Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants