Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update requirements with missing libs #104

Conversation

nikomakela
Copy link
Contributor

The pytests could not be ran before installing 2 missing dependencies: python-jose and cachetools.

The `pytest`s could not be ran before installing 2 missing dependencies:
`python-jose` and `cachetools`.
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.02%. Comparing base (b031c80) to head (56a01bd).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   56.12%   63.02%   +6.90%     
==========================================
  Files          31       29       -2     
  Lines        1062     1098      +36     
==========================================
+ Hits          596      692      +96     
+ Misses        466      406      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README says to install package requirements (which these two requirements are) with pip install -e . so technically these shouldn't be required here. 🤔

@charn
Copy link
Contributor

charn commented Jun 27, 2024

I'll close this, since requirements should be ok if installing them with pip install -e .

@charn charn closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants