test: ad groups update of the user model #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomakela
force-pushed
the
test-user-update_ad_groups
branch
2 times, most recently
from
485499a to
54417b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 56.12% 65.75% +9.63%
==========================================
Files 31 29 -2
Lines 1062 1098 +36
==========================================
+ Hits 596 722 +126
+ Misses 466 376 -90 ☔ View full report in Codecov by Sentry. |
charn
reviewed
Jun 26, 2024
helusers/tests/test_models.py
Outdated
Comment on lines
84
to
91
| # Nothing changes | ||
| ( | ||
| ALL_AD_GROUPS_MAPPING, | ||
| ALL_AD_GROUP_NAMES, | ||
| ALL_GROUP_NAMES, | ||
| ALL_AD_GROUP_NAMES, | ||
| ALL_GROUP_NAMES, | ||
| ), |
There was a problem hiding this comment.
Just FYI, you can do something like this, which would make it more obvious which part of the test fails.
Suggested change
| # Nothing changes | |
| ( | |
| ALL_AD_GROUPS_MAPPING, | |
| ALL_AD_GROUP_NAMES, | |
| ALL_GROUP_NAMES, | |
| ALL_AD_GROUP_NAMES, | |
| ALL_GROUP_NAMES, | |
| ), | |
| pytest.param( | |
| ALL_AD_GROUPS_MAPPING, | |
| ALL_AD_GROUP_NAMES, | |
| ALL_GROUP_NAMES, | |
| ALL_AD_GROUP_NAMES, | |
| ALL_GROUP_NAMES, | |
| id="nothing_changes", | |
| ), |
There was a problem hiding this comment.
I added the pytest-params with ids'.
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[nothing_changes] PASSED [ 46%]
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[not_mapped_not_added] PASSED [ 47%]
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[new_added] PASSED [ 47%]
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[old_removed] PASSED [ 47%]
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[mapped_twice_given_once] PASSED [ 48%]
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[mapped_twice_given_twice] PASSED [ 48%]
helusers/tests/test_models.py::TestUserAdGroups::test_update_ad_groups[all_removed] PASSED
charn
approved these changes
Jun 26, 2024
Test that the `update_ad_groups` function of the User-model works as expected: 1. If the same group is mapped to multiple ad-groups and the ad-groups input argument contains only some, the group is still persisted to user instance since it was mapped to at least one of given ad-groups. 2. If the ad-groups input argument does not have any link to an existing group of a user, the group is removed from the user instance. 3. If the ad-groups input argument contains links to new groups that the user is not yet linked to, the group will be added to the user instance.
nikomakela
force-pushed
the
test-user-update_ad_groups
branch
from
54417b7 to
f3201ad
Compare
@charn just a note that I don't have privileges to merge. The pr is from my fork because I didn't have privileges to add it to the real project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that the
update_ad_groupsfunction of the User-model works as expected:If the same group is mapped to multiple ad-groups and the ad-groups input argument contains only some, the group is still persisted to user instance since it was mapped to at least one of given ad-groups.
If the ad-groups input argument does not have any link to an existing group of a user, the group is removed from the user instance.
If the ad-groups input argument contains links to new groups that the user is not yet linked to, the group will be added to the user instance.