-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: migrate old user from Tunnistamo to Keycloak
Migration happens one user at a time upon login. Feature can be configured using the following settings. - `HELUSERS_USER_MIGRATE_ENABLED` enable the feature. Defaults to `False`. - `HELUSERS_USER_MIGRATE_EMAIL_DOMAINS` whitelisted email domains for migration. Defaults to `["hel.fi"]`. - `HELUSERS_USER_MIGRATE_AMRS` which authentication methods are used for migration. Defaults to `["helsinkiad"]`. Migration logic is only run on certain conditions: - Correct authentication method is used (AMR-claim) - Email domain is correct - User with the new UUID doesn't exist yet - Old user is found by email - Old user has username generated by helusers.utils.uuid_to_username Instead of allowing a new user to be created the migration is done by replacing the old user UUID with the one from the incoming token payload. Logic which is run later should take care of updating other user related fields. Primary key is separate from the user UUID, so the user UUID can be changed. This migration should therefore retain all the data related to the user. Migration logic only supports authentication methods from this package and Python Social Auth pipeline helusers.defaults.SOCIAL_AUTH_PIPELINE. This doesn't support migrating users which are using e.g. a different pipeline for Python Social Auth (e.g. the default pipeline). Refs: HP-2429
- Loading branch information
Showing
3 changed files
with
218 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,112 @@ | ||
import uuid | ||
|
||
import pytest | ||
from django.contrib.auth import get_user_model | ||
|
||
from helusers.user_utils import get_or_create_user, migrate_user | ||
from helusers.utils import uuid_to_username | ||
|
||
|
||
@pytest.fixture(autouse=True) | ||
def setup_migrate(settings): | ||
settings.HELUSERS_USER_MIGRATE_ENABLED = True | ||
settings.HELUSERS_USER_MIGRATE_AMRS = ["a", "b"] | ||
settings.HELUSERS_USER_MIGRATE_EMAIL_DOMAINS = ["example.com", "example.org"] | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"migrate_enabled, amr, email, good_username, expect_migration", | ||
[ | ||
pytest.param(True, ["a"], "[email protected]", True, True, id="migrate"), | ||
pytest.param( | ||
True, ["a"], "[email protected]", False, False, id="wrong_username" | ||
), | ||
pytest.param(True, ["c"], "[email protected]", True, False, id="wrong_amr"), | ||
pytest.param(True, ["a"], "[email protected]", True, False, id="wrong_domain"), | ||
pytest.param(False, ["a"], "[email protected]", True, False, id="disabled"), | ||
], | ||
) | ||
@pytest.mark.django_db | ||
def test_migrate_user( | ||
settings, migrate_enabled, amr, email, good_username, expect_migration | ||
): | ||
settings.HELUSERS_USER_MIGRATE_ENABLED = migrate_enabled | ||
old_uuid = uuid.uuid4() | ||
new_uuid = uuid.uuid4() | ||
old_username = uuid_to_username(old_uuid) if good_username else str(old_uuid) | ||
user_model = get_user_model() | ||
user = user_model.objects.create( | ||
uuid=old_uuid, | ||
username=old_username, | ||
first_name="A", | ||
last_name="User", | ||
email=email, | ||
) | ||
|
||
payload = { | ||
"sub": str(new_uuid), | ||
"amr": amr, | ||
"email": user.email, | ||
"first_name": user.first_name, | ||
"last_name": user.last_name, | ||
} | ||
|
||
migrate_user(user_id=str(new_uuid), payload=payload) | ||
|
||
if expect_migration: | ||
user.refresh_from_db() | ||
assert user.uuid == new_uuid | ||
assert user.username == uuid_to_username(new_uuid) | ||
else: | ||
user.refresh_from_db() | ||
assert user.uuid == old_uuid | ||
assert user.username == old_username | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"migrate_enabled, amr, email, good_username, expect_migration", | ||
[ | ||
pytest.param(True, ["a"], "[email protected]", True, True, id="migrate"), | ||
pytest.param( | ||
True, ["a"], "[email protected]", False, False, id="wrong_username" | ||
), | ||
pytest.param(True, ["c"], "[email protected]", True, False, id="wrong_amr"), | ||
pytest.param(True, ["a"], "[email protected]", True, False, id="wrong_domain"), | ||
pytest.param(False, ["a"], "[email protected]", True, False, id="disabled"), | ||
], | ||
) | ||
@pytest.mark.django_db | ||
def test_get_or_create_user_migrate_user( | ||
settings, migrate_enabled, amr, email, good_username, expect_migration | ||
): | ||
settings.HELUSERS_USER_MIGRATE_ENABLED = migrate_enabled | ||
old_uuid = uuid.uuid4() | ||
new_uuid = uuid.uuid4() | ||
user_model = get_user_model() | ||
old_user = user_model.objects.create( | ||
uuid=old_uuid, | ||
username=uuid_to_username(old_uuid) if good_username else str(old_uuid), | ||
first_name="A", | ||
last_name="User", | ||
email=email, | ||
) | ||
|
||
payload = { | ||
"sub": str(new_uuid), | ||
"amr": amr, | ||
"email": old_user.email, | ||
"first_name": old_user.first_name, | ||
"last_name": old_user.last_name, | ||
} | ||
|
||
user = get_or_create_user(payload) | ||
|
||
if expect_migration: | ||
assert user_model.objects.count() == 1 | ||
assert user.uuid == new_uuid | ||
assert user.username == uuid_to_username(new_uuid) | ||
else: | ||
assert user_model.objects.count() == 2 | ||
assert user_model.objects.filter(uuid=old_uuid).exists() | ||
assert user.uuid == new_uuid | ||
assert user.username == uuid_to_username(new_uuid) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters