Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAN-3705] Show moderated folders in BO 'Your projects' list #10224

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jinjagit
Copy link
Contributor

@jinjagit jinjagit commented Jan 30, 2025

  • When user moderates a folder, the folder is now shown in the 'Your projects' list.
  • The folder is initially shown in the collapsed state (as in the 'All' list)
  • Moderated projects in a moderated folder are not also shown outside of their folder.
  • Moderated projects in an unmoderated folder are still shown outside of their folder.
  • Counter in tab still counts n of moderated projects (whether they are in a folder or not)
SCREENSHOTS - Click me

User is folder mod (and mod of 2 projects in folder) + mod of 1 project not in folder:

Folder collapsed on page refresh:
Screenshot 2025-01-30 at 14 38 47

Folder expanded:
Screenshot 2025-01-30 at 14 38 55

User is project mod of 2 projects (1 in folder, 1 not in folder):

Screenshot 2025-01-30 at 14 39 41

Changelog

Changed

  • [TAN-3705] Show moderated folders in BO 'Your projects' list
    • Moderator of folder will now see their moderated folder(s) in 'Your projects' tab.
    • Behaviour unchanged for moderators of only projects.

@jinjagit jinjagit self-assigned this Jan 30, 2025
Copy link

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Jan 30, 2025

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-3705
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against dbb93e9

@jinjagit
Copy link
Contributor Author

jinjagit commented Jan 30, 2025

@brentguf I feel like I should be adding a FE unit test or two here, but I couldn't find any tests of similar functionality at this kind of granularity.

useAdminPublications.test.ts seems much higher-level in its concerns, for example.

Do you know of any example tests of something like the new const flatModeratedProjectAdminPublications I have added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants